-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add gemini-embedding-001 model to code-index service #5698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add gemini-embedding-001 with 3072 dimensions to EMBEDDING_MODEL_PROFILES - Update GeminiEmbedder to support multiple models via constructor parameter - Set gemini-embedding-001 as the default Gemini model - Update service-factory to pass modelId to GeminiEmbedder - Remove hardcoded dimension logic for Gemini provider - Update tests to support new model parameter and correct dimensions The new model provides state-of-the-art performance across English, multilingual and code tasks, unifying previously specialized models.
|
✅ No security or compliance issues detected. Reviewed everything up to 4c71f27. Security Overview
Detected Code Changes
Reply to this PR with |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
mrubens
approved these changes
Jul 14, 2025
chrarnoldus
added a commit
to Kilo-Org/kilocode
that referenced
this pull request
Jul 16, 2025
cherry picked from RooCodeInc/Roo-Code#5698
fxcl
added a commit
to tameslabs/Roo-Cline
that referenced
this pull request
Jul 16, 2025
* main: fix: Resolve confusing auto-approve checkbox states (RooCodeInc#5602) fix: prevent empty mode names from being saved (RooCodeInc#5766) (RooCodeInc#5794) Format time in ISO 8601 (RooCodeInc#5793) fix: resolve DirectoryScanner memory leak and improve file limit handling (RooCodeInc#5785) Fix settings dirty check (RooCodeInc#5779) feat: increase Ollama API timeout values and extract as constants (RooCodeInc#5778) fix: Exclude Terraform and Terragrunt cache directories from checkpoints (RooCodeInc#4601) (RooCodeInc#5750) Move less commonly used provider settings into an advanced dropdown (RooCodeInc#5762) feat: Add configurable error & repetition limit with unified control (RooCodeInc#5654) (RooCodeInc#5752) list-files must include at least the first-level directory contents (RooCodeInc#5303) Update evals repo link (RooCodeInc#5758) Feature/vertex ai model name conversion (RooCodeInc#5728) fix(litellm): handle baseurl with paths correctly (RooCodeInc#5697) Add telemetry for todos (RooCodeInc#5746) feat: add undo functionality for enhance prompt feature (fixes RooCodeInc#5741) (RooCodeInc#5742) Fix max_tokens limit for moonshotai/kimi-k2-instruct on Groq (RooCodeInc#5740) Changeset version bump (RooCodeInc#5735) Add changeset for v3.23.12 patch release (RooCodeInc#5734) Update the max-token calculation in model-params to use the shared logic (RooCodeInc#5720) Changeset version bump (RooCodeInc#5719) chore: add changeset for v3.23.11 patch release (RooCodeInc#5718) Add Kimi K2 model and better support (RooCodeInc#5717) Fix: Remove invalid skip-checkout parameter from GitHub Actions workflows (RooCodeInc#5676) feat: add Cmd+Shift+. keyboard shortcut for previous mode switching (RooCodeInc#5695) Changeset version bump (RooCodeInc#5708) chore: add changeset for v3.23.10 patch release (RooCodeInc#5707) Add padding to the index model options (RooCodeInc#5706) fix: prioritize built-in model dimensions over custom dimensions (RooCodeInc#5705) Update CHANGELOG.md Changeset version bump (RooCodeInc#5702) chore: add changeset for v3.23.9 patch release (RooCodeInc#5701) Tweaks to command timeout error (RooCodeInc#5700) Update contributors list (RooCodeInc#5639) feat: enable Claude Code provider to run natively on Windows (RooCodeInc#5615) feat: Add configurable timeout for command execution (RooCodeInc#5668) feat: add gemini-embedding-001 model to code-index service (RooCodeInc#5698) fix: resolve vector dimension mismatch error when switching embedding models (RooCodeInc#5616) (RooCodeInc#5617) fix: [5424] return the cwd in the exec tool's response so that the model is not lost after subsequent calls (RooCodeInc#5667) Changeset version bump (RooCodeInc#5670) chore: add changeset for v3.23.8 patch release (RooCodeInc#5669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Google's new gemini-embedding-001 model to the code-index service. This model provides state-of-the-art performance across English, multilingual, and code tasks, unifying previously specialized models.
Changes Made
Model Specifications
Testing
UI Support
The existing CodeIndexPopover component already supports displaying Gemini models in a dropdown, so users will automatically see both available models:
Breaking Changes
None. The changes are backward compatible - existing configurations using text-embedding-004 will continue to work.
Important
Add support for
gemini-embedding-001model to code-index service, updatingGeminiEmbedderand tests for multiple model handling.gemini-embedding-001model toembeddingModels.tswith dimension 3072.gemini-embedding-001as default model ingetDefaultModelId().GeminiEmbedderto accept model ID via constructor, defaulting togemini-embedding-001.createEmbeddings()inGeminiEmbedderto use instance or provided model.createEmbedder()inservice-factory.tsto pass model ID toGeminiEmbedder.createVectorStore().service-factory.spec.tsandgemini.spec.tsto handle new model parameter and dimensions.This description was created by
for fe877f9. You can customize this summary. It will automatically update as commits are pushed.